[phenotips/patient-network] e491a6: PN-253: Create a configuration table to show the l...

GitHub noreply at github.com
Mon Jan 22 15:16:33 EST 2018


  Branch: refs/heads/PN-253
  Home:   https://github.com/phenotips/patient-network
  Commit: e491a6440c7e9cf9a567ac875b3d1d986cac82cb
      https://github.com/phenotips/patient-network/commit/e491a6440c7e9cf9a567ac875b3d1d986cac82cb
  Author: veronikaslc <veronika.koltunov at gmail.com>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    A ui/src/main/resources/PhenoTips/MatchingRunInfo.xml
    A ui/src/main/resources/PhenoTips/MatchingRunInfoClass.xml

  Log Message:
  -----------
  PN-253: Create a configuration table to show the last date+time matching was run


  Commit: 2e433767b03015ef5d4f6d62a37681afd58d89fd
      https://github.com/phenotips/patient-network/commit/2e433767b03015ef5d4f6d62a37681afd58d89fd
  Author: veronikaslc <veronika.koltunov at gmail.com>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/MatchFinder.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/MatchFinderManager.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/internal/DefaultMatchFinderManager.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/internal/LocalMatchFinder.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/internal/DefaultMatchingNotificationManager.java
    M pom.xml

  Log Message:
  -----------
  PN-252: Run local matches search only for patients updated/created since last search


  Commit: bffc67f666bfb225eddbb0e3a7de089e82c194d6
      https://github.com/phenotips/patient-network/commit/bffc67f666bfb225eddbb0e3a7de089e82c194d6
  Author: veronikaslc <veronika.koltunov at gmail.com>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/MatchFinderManager.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/internal/DefaultMatchFinderManager.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/internal/LocalMatchFinder.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/internal/DefaultMatchingNotificationManager.java
    M pom.xml

  Log Message:
  -----------
  PN-252: Run local matches search only for patients updated/created since last search
Addressing codereview comments


  Commit: 63448ba54daa9d757daaa0c8541bd8d66b3fa50a
      https://github.com/phenotips/patient-network/commit/63448ba54daa9d757daaa0c8541bd8d66b3fa50a
  Author: Andrew Misyura <asm at phenotips.org>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/internal/LocalMatchFinder.java

  Log Message:
  -----------
  PN-252: Run local matches search only for patients updated/created since last search

Added more logging and more error catching


  Commit: 8303f6c19662c313aad54e3682ca358b103a06be
      https://github.com/phenotips/patient-network/commit/8303f6c19662c313aad54e3682ca358b103a06be
  Author: Andrew Misyura <asm at phenotips.org>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/MatchFinderManager.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/internal/DefaultMatchFinderManager.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/internal/DefaultMatchingNotificationManager.java
    M pom.xml

  Log Message:
  -----------
  PN-252: Run local matches search only for patients updated/created since last search

Simplified the API a bit


  Commit: d837ab09ceb1677341bcc408769fa51522509d42
      https://github.com/phenotips/patient-network/commit/d837ab09ceb1677341bcc408769fa51522509d42
  Author: Andrew Misyura <asm at phenotips.org>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/internal/DefaultMatchFinderManager.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/internal/LocalMatchFinder.java
    R ui/src/main/resources/PhenoTips/MatchingRunInfo.xml
    M ui/src/main/resources/PhenoTips/MatchingRunInfoClass.xml
    A ui/src/main/resources/PhenoTips/MatchingUpdateAndInfo.xml

  Log Message:
  -----------
  PN-252: Run local matches search only for patients updated/created since last search

Added statistics about patients affected by the match


  Commit: 8c8bc127b36b5bfb67fb1a7c5f784f8d68a6322d
      https://github.com/phenotips/patient-network/commit/8c8bc127b36b5bfb67fb1a7c5f784f8d68a6322d
  Author: Andrew Misyura <asm at phenotips.org>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/MatchFinder.java
    A matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/internal/AbstractMatchFinder.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/internal/LocalMatchFinder.java

  Log Message:
  -----------
  PN-252: Run local matches search only for patients updated/created since last search

Refactored code
 - separated common matcher functionality into AbstractMatchFinder
 - extended MatchFinder API to provide more control over matching process


  Commit: 57a0ce565ca8ceda1f61fcc5b1b8efb6822afd20
      https://github.com/phenotips/patient-network/commit/57a0ce565ca8ceda1f61fcc5b1b8efb6822afd20
  Author: Andrew Misyura <asm at phenotips.org>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/MatchingNotificationManager.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/MatchFinderManager.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/finder/internal/DefaultMatchFinderManager.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/internal/DefaultMatchingNotificationManager.java
    M matching-notification-api/src/main/java/org/phenotips/matchingnotification/script/MatchingNotificationScriptService.java

  Log Message:
  -----------
  PN-252: Run local matches search only for patients updated/created since last search

Back-end changes in various MatchingNotification components to allow better control over what matches are found


  Commit: f5113134e96efc0d89e4d1b3f06f241830a4bf1b
      https://github.com/phenotips/patient-network/commit/f5113134e96efc0d89e4d1b3f06f241830a4bf1b
  Author: Andrew Misyura <asm at phenotips.org>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M pom.xml

  Log Message:
  -----------
  PN-252: Run local matches search only for patients updated/created since last search

pom.xml update


  Commit: 08b778a226e86acc0d9c96fd5ddf0e841c3fff84
      https://github.com/phenotips/patient-network/commit/08b778a226e86acc0d9c96fd5ddf0e841c3fff84
  Author: Andrew Misyura <asm at phenotips.org>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M matching-notification-api/src/main/resources/ApplicationResources.properties
    A matching-notification-resources/src/main/resources/resources/uicomponents/matchingNotification/findMatches.css
    A matching-notification-resources/src/main/resources/resources/uicomponents/matchingNotification/findMatches.js
    M matching-notification-resources/src/main/resources/resources/uicomponents/matchingNotification/matchesTable.css
    M matching-notification-resources/src/main/resources/resources/uicomponents/matchingNotification/notifiedMatchesTable.js
    M matching-notification-resources/src/main/resources/resources/uicomponents/matchingNotification/unnotifiedMatchesTable.js
    M matching-notification-resources/src/main/resources/resources/uicomponents/matchingNotification/utils.js
    A matching-notification-ui/src/main/resources/MatchingNotification/MatchingRunInfoClass.xml
    A matching-notification-ui/src/main/resources/MatchingNotification/MatchingUpdateAndInfo.xml
    M matching-notification-ui/src/main/resources/MatchingNotification/RequestHandler.xml
    M matching-notification-ui/src/main/resources/MatchingNotification/UnnotifiedTable.xml
    R ui/src/main/resources/PhenoTips/MatchingRunInfoClass.xml
    R ui/src/main/resources/PhenoTips/MatchingUpdateAndInfo.xml

  Log Message:
  -----------
  PN-252: Run local matches search only for patients updated/created since last search

UI changes:
  - moved "find matches" button from the matching notification page to the "refresh matches" page
  - added separate buttons to find local matches and remore matches, as well as find all matches or only matches for updated patients
  - moved some .xml files around to have them in the same place with other code using common .js files


Compare: https://github.com/phenotips/patient-network/compare/3457474ec20a...08b778a226e8


More information about the notifications mailing list